fix(@angular/cli): support string | boolean union types in CLI options #31821
+83
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the CLI's command builder to correctly handle JSON schema properties that define a union type of `string` and `boolean`. Previously, only the first type in a union was considered, preventing options like `--runner-config` from being used as both a boolean flag and a string value.
Collaborator
|
Will false in the following case would be great to add a couple of unit tests. |
clydin
added
action: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances the CLI's command builder to correctly handle JSON schema properties that define a union type of
stringandboolean. Previously, only the first type in a union was considered, preventing options like--runner-configfrom being used as both a boolean flag and a string value.